]> Cypherpunks repositories - gostls13.git/commit
net/http: fix a data race when Request.Cancel is used
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 24 Jul 2015 23:27:07 +0000 (16:27 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 27 Jul 2015 04:07:23 +0000 (04:07 +0000)
commitda87cf5dcf342a31c82ff7980bdc076558ff6674
treeb71b7c1bfc1aa8d5e89e39ce6f90cd39eb793e6e
parent56a062400a8c4654eaca78c2926f2724a21cda61
net/http: fix a data race when Request.Cancel is used

The "add a Request.Cancel channel" change (https://golang.org/cl/11601)
added support for "race free" cancellation, but introduced a data race. :)

Noticed while running "go test -race net/http". The test is skipped in
short mode, so we never saw it on the dashboard.

Change-Id: Ica14579d8723f8f9d1691e8d56c30b585b332c64
Reviewed-on: https://go-review.googlesource.com/12663
Reviewed-by: Aaron Jacobs <jacobsa@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/http/transport.go