]> Cypherpunks repositories - gostls13.git/commit
cmd/link: remove dummy argument from ld.Errorf
authorRuss Cox <rsc@golang.org>
Fri, 1 Nov 2024 18:56:25 +0000 (14:56 -0400)
committerRuss Cox <rsc@golang.org>
Thu, 7 Nov 2024 12:17:55 +0000 (12:17 +0000)
commitdaa6c9310e6bc94426b04f908962dff558209408
treeeda011b42f3dd7745deecb96afdb2f09277e98cf
parent5b20eec8a0eb3bd4681e315c0c4023c5164ea7b9
cmd/link: remove dummy argument from ld.Errorf

As the comment notes, all calls to Errorf now pass nil,
so remove that argument entirely.

There is a TODO to remove uses of Errorf entirely, but
that seems wrong: sometimes there is no symbol on
which to report the error, and in that situation, Errorf is
appropriate. So clarify that in the docs.

Change-Id: I92b3b6e8e3f61ba8356ace8cd09573d0b55d7869
Reviewed-on: https://go-review.googlesource.com/c/go/+/625617
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
15 files changed:
src/cmd/link/internal/ld/ar.go
src/cmd/link/internal/ld/data.go
src/cmd/link/internal/ld/dwarf.go
src/cmd/link/internal/ld/elf.go
src/cmd/link/internal/ld/go.go
src/cmd/link/internal/ld/ld.go
src/cmd/link/internal/ld/lib.go
src/cmd/link/internal/ld/macho.go
src/cmd/link/internal/ld/main.go
src/cmd/link/internal/ld/pcln.go
src/cmd/link/internal/ld/pe.go
src/cmd/link/internal/ld/util.go
src/cmd/link/internal/ld/xcoff.go
src/cmd/link/internal/riscv64/asm.go
src/cmd/link/internal/wasm/asm.go