]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: restrict ppc64 constant shifts to amount 0-63
authorKeith Randall <khr@golang.org>
Thu, 7 May 2020 22:16:25 +0000 (15:16 -0700)
committerKeith Randall <khr@golang.org>
Mon, 11 May 2020 15:33:30 +0000 (15:33 +0000)
commitdaf39d06ee04414fa962aa61fd0e7bc4ee166bfd
tree3d33672daf9e4d822e097080b9ffa59401278f61
parentd40b0a1494cc3b717207ce822d01d0f180627a3f
cmd/compile: restrict ppc64 constant shifts to amount 0-63

... and 0-31 for 32-bit shifts.

Generally update the docs for ppc64 shift instructions to be
clearer about what they actually do.

This issue is causing problems for the subsequent CL. The shift
amount was <0 and caused the assembler to report an invalid instruction.

Change-Id: I8c708a15e7f71931835e6e543d8db3c716186e52
Reviewed-on: https://go-review.googlesource.com/c/go/+/232858
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
src/cmd/compile/internal/ssa/gen/PPC64.rules
src/cmd/compile/internal/ssa/gen/PPC64Ops.go
src/cmd/compile/internal/ssa/rewritePPC64.go