]> Cypherpunks repositories - gostls13.git/commit
runtime: make traceback indicate whether _defer was just allocated
authorAustin Clements <austin@google.com>
Mon, 17 Dec 2018 19:23:56 +0000 (14:23 -0500)
committerAustin Clements <austin@google.com>
Mon, 17 Dec 2018 21:24:13 +0000 (21:24 +0000)
commitdb1e8a9e1f1b019dd7928ea239d5b0e4af66d9a6
treea6ff9ad9a7c8da5c070cac56b3d4b9316652b953
parent3c255e8bc6964ebee580b44835ddbe95c893e29f
runtime: make traceback indicate whether _defer was just allocated

Many of the crashes observed in #27993 involve committing the new
_defer object at the end of newdefer. It would be helpful to know if
the _defer was just allocated or was retrieved from the defer pool. In
order to indicate this in the traceback, this CL duplicates the tail
of newdefer so that the PC/line number will tell us whether d is new
or not.

For #27993.

Change-Id: Icd3e23dbcf00461877bb082b6f18df701149a607
Reviewed-on: https://go-review.googlesource.com/c/154598
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/panic.go