]> Cypherpunks repositories - gostls13.git/commit
cmd/link: remove unused flag -D (FlagDataAddr)
authorAlex Tokarev <aleksator@gmail.com>
Fri, 23 Nov 2018 06:45:51 +0000 (13:45 +0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 1 Mar 2019 02:14:00 +0000 (02:14 +0000)
commitdb2b6e15667f9001bbd1ef133ce64328cd329166
treea20e00f2521722eab19817521d965f3d13850a73
parentaafa855fd3f50f8d5c69a9f0e1ff06c50cfdcd64
cmd/link: remove unused flag -D (FlagDataAddr)

FlagDataAddr is a vestige from git commit 0cafb9e (2008;
no Gerrit CL number).

It was never used but unfortunately setting it would
cause a spurious warning:

  warning: -D<value> is ignored because of -R0x1000

yet if -R was unset e.g. -R=0, the linker would crash
with a divide by zero runtime panic.

Fixes #28921

Change-Id: Ia910399bc269337a9a860f3a26cd48fae6e62724
Reviewed-on: https://go-review.googlesource.com/c/151021
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/link/internal/amd64/obj.go
src/cmd/link/internal/arm/obj.go
src/cmd/link/internal/arm64/obj.go
src/cmd/link/internal/ld/main.go
src/cmd/link/internal/ld/pe.go
src/cmd/link/internal/ld/xcoff.go
src/cmd/link/internal/mips/obj.go
src/cmd/link/internal/mips64/obj.go
src/cmd/link/internal/ppc64/obj.go
src/cmd/link/internal/s390x/obj.go
src/cmd/link/internal/x86/obj.go