]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix typing of atomic logical operations
authorKeith Randall <khr@golang.org>
Tue, 25 Jun 2024 21:01:09 +0000 (14:01 -0700)
committerKeith Randall <khr@golang.org>
Tue, 23 Jul 2024 21:27:54 +0000 (21:27 +0000)
commitdbfa3cacc7a4178ff3b81c79f7678ac9d61c54ab
treed029987f41b6973fc482795cce99cc0db7ad4ea4
parentdf009eead9c2d213bc9c6057f07d2c319f71b50b
cmd/compile: fix typing of atomic logical operations

For atomic AND and OR operations on memory, we currently have two
views of the op. One just does the operation on the memory and returns
just a memory. The other does the operation on the memory and returns
the old value (before having the logical operation done to it) and
memory.

Update #61395

These two type differently, and there's currently some confusion in
our rules about which is which. Use different names for the two
different flavors so we don't get them confused.

Change-Id: I07b4542db672b2cee98169ac42b67db73c482093
Reviewed-on: https://go-review.googlesource.com/c/go/+/594976
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Nicolas Hillegeer <aktau@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
src/cmd/compile/internal/ssa/_gen/ARM64.rules
src/cmd/compile/internal/ssa/_gen/genericOps.go
src/cmd/compile/internal/ssa/opGen.go
src/cmd/compile/internal/ssa/rewriteARM64.go
src/cmd/compile/internal/ssagen/ssa.go