]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] runtime: mark assembly functions called directly from compiler ABIIn...
authorCherry Mui <cherryyz@google.com>
Thu, 27 May 2021 22:07:36 +0000 (18:07 -0400)
committerCherry Mui <cherryyz@google.com>
Wed, 2 Jun 2021 16:49:25 +0000 (16:49 +0000)
commitdc2cb529a8c9e4b771163be1974ef39d76c3f548
tree9fd9f65db7b3b9044e332eeb75bde75df20194da
parentd2b435117d3a1db612ad894125b8ab673a5a46ee
[dev.typeparams] runtime: mark assembly functions called directly from compiler ABIInternal

For functions such as gcWriteBarrier and panicIndexXXX, the
compiler generates ABIInternal calls directly. And they must not
use wrappers because it follows a special calling convention or
the caller's PC is used. Mark them as ABIInternal.

Note that even though they are marked as ABIInternal, they don't
actually use the internal ABI, i.e. regabiargs is not honored for
now.

Now all.bash passes with GOEXPERIMENT=regabiwrappers (at least on
macOS).

Change-Id: I87e41964e6dc4efae03e8eb636ae9fa1d99285bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/323934
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/cmd/internal/obj/arm64/obj7.go
src/runtime/asm_arm64.s
src/runtime/duff_arm64.s
src/runtime/mkduff.go
src/runtime/race_arm64.s