]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/syntax: remove unused field in (scanner) source
authorRobert Griesemer <gri@golang.org>
Wed, 5 Dec 2018 22:42:47 +0000 (14:42 -0800)
committerRobert Griesemer <gri@golang.org>
Wed, 5 Dec 2018 23:15:21 +0000 (23:15 +0000)
commitdc7808d4f2989fa0514fc0e4014616fdb8c4a764
tree1d29468c03f46b49da813b807c4b91dfca151d92
parent940e5bc5617ed86fcbf845fdd1973be984259a59
cmd/compile/internal/syntax: remove unused field in (scanner) source

The source.offs field was intended for computing line offsets which
may allow a tiny optimization (see TODO in source.go). We haven't
done the optimization, so for now just remove the field to avoid
confusion. It's trivially added if needed.

While at it, also:

- Fix comment for ungetr2.
- Make sure sentinel is present even if reading from the io.Reader failed.

Change-Id: Ib056c6478030b3fe5fec29045362c8161ff3d19e
Reviewed-on: https://go-review.googlesource.com/c/152763
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/syntax/source.go