]> Cypherpunks repositories - gostls13.git/commit
net: combine append calls in reverseaddr
authorIskander Sharipov <iskander.sharipov@intel.com>
Sat, 9 Jun 2018 17:43:54 +0000 (20:43 +0300)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 20 Aug 2018 05:23:29 +0000 (05:23 +0000)
commitdc79206aec20b92388e7050d0359dccccd31ef0b
tree4cceab71d3e13b2183255d09ae8e64c2b3c16e1c
parente0faedbb5344eb6f8f704005fe88961cdc6cf5f8
net: combine append calls in reverseaddr

Combined appends lead to fewer machine code and faster performance.
Some may even say that it makes code more readable.

Running revAddrTests over reverseaddr gives measurable improvements:

name              old time/op  new time/op  delta
ReverseAddress-8  4.10µs ± 3%  3.94µs ± 1%  -3.81%  (p=0.000 n=10+9)

Change-Id: I9bda7a20f802bcdffc6e948789765d04c6da04e7
Reviewed-on: https://go-review.googlesource.com/117615
Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/dnsclient.go