]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: remove duplicate const logic from typecheck
authorMatthew Dempsky <mdempsky@google.com>
Mon, 7 Mar 2022 16:54:28 +0000 (08:54 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Mon, 7 Mar 2022 18:17:40 +0000 (18:17 +0000)
commitdcb6547b76c5818b55294e203e8f5057794b23cf
treed0af91f84ed3a3efabf6652ca18723fa89b3039c
parentcc9d3f548a0265124766dfdb45e77cf05579219d
cmd/compile: remove duplicate const logic from typecheck

Now that we always use types2 to validate user source code, we can
remove the constSet logic from typecheck for detecting duplicate
expression switch cases and duplicate map literal keys. This logic is
redundant with types2, and currently causes unified IR to report
inappropriate duplicate constant errors that only appear after type
substitution.

Updates #42758.

Change-Id: I51ee2c5106eec9abf40eba2480dc52603c68ba21
Reviewed-on: https://go-review.googlesource.com/c/go/+/390474
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/noder/reader.go
src/cmd/compile/internal/typecheck/const.go
src/cmd/compile/internal/typecheck/expr.go
src/cmd/compile/internal/typecheck/stmt.go
test/typeparam/issue42758.go [new file with mode: 0644]