]> Cypherpunks repositories - gostls13.git/commit
runtime: remove TestCrashExitCode
authorqmuntal <quimmuntal@gmail.com>
Mon, 8 May 2023 11:31:37 +0000 (13:31 +0200)
committerQuim Muntal <quimmuntal@gmail.com>
Mon, 8 May 2023 16:57:33 +0000 (16:57 +0000)
commitdd78bc0564509f8c410d6467f6c4c74646bfb224
treecc079ee875f4665b6b241daadf233e1063ad069b
parentbc3bdfa977628cfa2c6079eef71fab3e8d923d59
runtime: remove TestCrashExitCode

TestCrashExitCode was added in CL 491935 to test that the exit code
is honored when using GOTRACEBACK=crash, which is what normally happens
on a stock Windows. The problem is that some applications (not only WER,
as I incorrectly assumed in CL 491935) can hijack a crashing process
and change its exit code.

There is no way to tell if a crashing process using GOTRACEBACK=crash/
wer will have its error code hijacked, so we better don't test this
behavior, which in fact is not documented by the Go runtime.

Change-Id: Ib8247a8a1fe6303c4c7812a1bf2ded5f4e89acb1
Reviewed-on: https://go-review.googlesource.com/c/go/+/493495
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/runtime/syscall_windows_test.go