]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: additional paranoia and checking in plive.go
authorRuss Cox <rsc@golang.org>
Wed, 25 May 2016 14:01:58 +0000 (10:01 -0400)
committerRuss Cox <rsc@golang.org>
Fri, 27 May 2016 14:13:11 +0000 (14:13 +0000)
commitdec1bae916fc75a6718fb7fa667e419cc902097a
tree96e8e9358f79c1b8b8d7e539303c5e199db1a9fe
parente9228dd9490c3d4827170abeb8c82e68c175ecf0
cmd/compile: additional paranoia and checking in plive.go

The main check here is that liveness now crashes if it finds an instruction
using a variable that should be tracked but is not.

Comments and adjustments in nodarg to explain what's going on and
to remove the "-1" argument added a few months ago, plus a sketch
of a future simplification.

The need for n.Orig in the earlier CL seems to have been an intermediate
problem rather than fundamental: the new explanations in nodarg make
clear that nodarg is not causing the problem I thought, and in fact now
using n instead of n.Orig works fine in plive.go.

Change-Id: I3f5cf9f6e4438a6d27abac7d490e7521545cd552
Reviewed-on: https://go-review.googlesource.com/23450
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/gc/closure.go
src/cmd/compile/internal/gc/dcl.go
src/cmd/compile/internal/gc/fmt.go
src/cmd/compile/internal/gc/gsubr.go
src/cmd/compile/internal/gc/plive.go
src/cmd/compile/internal/gc/type.go
src/cmd/compile/internal/gc/universe.go
src/cmd/compile/internal/gc/walk.go