]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/types2: review of stdlib_test.go
authorRobert Griesemer <gri@golang.org>
Tue, 23 Mar 2021 19:30:18 +0000 (12:30 -0700)
committerRobert Griesemer <gri@golang.org>
Thu, 25 Mar 2021 04:21:29 +0000 (04:21 +0000)
commitdec3d00b28657ce9e2fe725c858a46c3dd3fd594
tree0ab38e36a450ae8a6460907341326188fb472c41
parentddcdbb417b47e50fc7006c9438104c5b8b5f75e4
cmd/compile/internal/types2: review of stdlib_test.go

The changes between (equivalent, and reviewed) go/types/stdlib_test.go
and stdlib_test.go can be seen by comparing patchset 1 and 2. The actual
changes are removing the "// UNREVIEWED" marker, using the os package
instead of ioutil, and some comment adjustments. Also, bug251.go passes
because of recent changes.

The primary difference is in the firstComment function which
doesn't have access to a scanner and instead uses the syntax
package's CommentsDu function.

Change-Id: I946ffadc97e87c692f76f369a1b16cceee528477
Reviewed-on: https://go-review.googlesource.com/c/go/+/304130
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/types2/stdlib_test.go