]> Cypherpunks repositories - gostls13.git/commit
cmd/link/internal/ld: more fixes to TestElfBindNow readonly .got check
authorThan McIntosh <thanm@google.com>
Fri, 26 Apr 2024 13:10:36 +0000 (13:10 +0000)
committerThan McIntosh <thanm@google.com>
Fri, 26 Apr 2024 15:38:14 +0000 (15:38 +0000)
commitdeeebf5655eeb91e93e60dbda5c3df294b4d5130
tree71c45ea959785796234ab3d45195c02898649a1c
parent2dd82d97b67a538700e30d808122a521e3207c3e
cmd/link/internal/ld: more fixes to TestElfBindNow readonly .got check

Second try at fixing the TestElfBindNow testpoint: don't try to check
for readonly ".got" section when using the external linker, since
there is code in some linkers (BFD in particular) that will skip
placing ".got" in relro if the section is below a specific size
threshold. Revised version of the test checks only for readonly
".dynamic" in the external linking case.

Fixes #67063.

Change-Id: Idb6b82ec7893baddf171654775587f6050fc6258
Reviewed-on: https://go-review.googlesource.com/c/go/+/581995
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: abner chenc <chenguoqi@loongson.cn>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/link/internal/ld/elf_test.go