]> Cypherpunks repositories - gostls13.git/commit
go/types: ignore artificial cycles introduced via method declarations
authorRobert Griesemer <gri@golang.org>
Fri, 29 Jun 2018 21:46:57 +0000 (14:46 -0700)
committerRobert Griesemer <gri@golang.org>
Tue, 10 Jul 2018 16:36:50 +0000 (16:36 +0000)
commitdeefcb26233c8acd089e9ae1d247c13891b6c55c
treeb9e6ced70514d57dccef28f671318d651d898d92
parentfa71076d242d0f9da48080dd9ddfd9c0f8a469cb
go/types: ignore artificial cycles introduced via method declarations

At the moment, method declarations are type-checked together with
they receiver base types. This is a known problem (to be fixed early
for Go 1.12) but with the new cycle detection algorithm now also
introduced artifical type cycles.

This change pushes a special marker on the cycle path in those cases
so that these cycles can be ignored.

Fixes #26124.

Change-Id: I64da4ccc32d4ae293da48880c892154a1c6ac3fe
Reviewed-on: https://go-review.googlesource.com/121757
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
src/go/types/decl.go
src/go/types/testdata/issues.src