]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] cmd/compile: skip escape analysis diagnostics for wrappers
authorMatthew Dempsky <mdempsky@google.com>
Thu, 24 Jun 2021 16:07:52 +0000 (09:07 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 24 Jun 2021 18:24:24 +0000 (18:24 +0000)
commitdf00abc61b415eb05d4df9fd2bf3fdda1aaaaba3
treee14f08c8088d5a8dc1849031e79c8dc180e7d7f3
parentb55cc6687d8f805663e9e803ad5293d1b399ce37
[dev.typeparams] cmd/compile: skip escape analysis diagnostics for wrappers

This CL changes escape analysis to skip reporting diagnostics (at
least for parameter tagging) for generated wrappers.

We're inconsistent about when/where wrappers are generated, which made
errorcheck tests of escape analysis unnecessarily brittle to changes
in wrapper generation. This CL addresses this making errorcheck tests
only care about tagging of the actual functions themselves, not the
wrappers too.

Change-Id: Ia1a0b9dabee4d4162b05647f871db03b032c945a
Reviewed-on: https://go-review.googlesource.com/c/go/+/330689
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/escape/escape.go
test/uintptrescapes2.go