]> Cypherpunks repositories - gostls13.git/commit
runtime: improve last ditch signal forwarding for Unix libraries
authorJoe Sylve <joe.sylve@gmail.com>
Wed, 23 Mar 2016 03:11:42 +0000 (22:11 -0500)
committerIan Lance Taylor <iant@golang.org>
Thu, 24 Mar 2016 19:34:17 +0000 (19:34 +0000)
commitdf2b2eb63db3f771c41be4d97ac6fb6b0c5f8c48
tree562b13708225cadb605d4abf10afdb692e32fd54
parentfb49655d7b3a319dfbf48ad55dd7951a91668949
runtime: improve last ditch signal forwarding for Unix libraries

The current runtime attempts to forward signals generated by non-Go
code to the original signal handler.  If it can't call the original
handler directly, it currently attempts to re-raise the signal after
resetting the handler.  In this case, the original context is lost.

This fix prevents that problem by simply returning from the go signal
handler after resetting the original handler.  It only does this when
the original handler is the system default handler, which in all cases
is known to not recover.  The signal is not reset, so it is retriggered
and the original handler takes over with the proper context.

Fixes #14899

Change-Id: Ib1c19dfa4b50d9732d7a453de3784c8141e1cbb3
Reviewed-on: https://go-review.googlesource.com/21006
Reviewed-by: Ian Lance Taylor <iant@golang.org>
misc/cgo/testcarchive/carchive_test.go
misc/cgo/testcarchive/main5.c [new file with mode: 0644]
src/runtime/os1_nacl.go
src/runtime/signal1_unix.go
src/runtime/signal_darwin.go
src/runtime/signal_freebsd.go
src/runtime/signal_openbsd.go
src/runtime/signal_sigtramp.go
src/runtime/signal_solaris_amd64.go
src/runtime/sigqueue.go
src/runtime/sys_solaris_amd64.s