]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.21] cmd/go: fix build config before creating actions for 'go...
authorEhden Sinai <ehdens@gmail.com>
Thu, 1 Feb 2024 18:38:56 +0000 (13:38 -0500)
committerCarlos Amedee <carlos@golang.org>
Wed, 10 Jul 2024 19:27:26 +0000 (19:27 +0000)
commite073febe901cecb3737c712b6d53a8c48684ffb5
tree3aa62385ec588aeb08497d07d57effcc60e68dad
parent12e9b968bc8890b072b98facbd079ca337bd33a0
[release-branch.go1.21] cmd/go: fix build config before creating actions for 'go list -cover'

When -covermode is set to atomic, instrumented packages need to import
sync/atomic. If this is not already imported by a package being
instrumented, the build needs to ensure that sync/atomic is compiled
whenever 'go list' is run in a way that triggers package builds.

The build config was already being made to ensure the import, but only
after the action graph had been created, so there was no guarantee that
sync/atomic would be built when needed.

For #65264
For #68212
Fixes #68221

Change-Id: Ib3f1e102ce2ef554ea08330d9db69a8c98790ac5
Reviewed-on: https://go-review.googlesource.com/c/go/+/560236
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
(cherry picked from commit ac08c05d4daa11957fcada6db33f2150936bac27)
Reviewed-on: https://go-review.googlesource.com/c/go/+/595495
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
src/cmd/go/internal/list/list.go
src/cmd/go/testdata/script/cover_list.txt