]> Cypherpunks repositories - gostls13.git/commit
[dev.link] cmd/internal/goobj2: add index fingerprint to object file
authorCherry Zhang <cherryyz@google.com>
Wed, 22 Apr 2020 23:21:30 +0000 (19:21 -0400)
committerCherry Zhang <cherryyz@google.com>
Fri, 24 Apr 2020 17:47:14 +0000 (17:47 +0000)
commite08f10b8b5fbb82ff1e2c263ad57e19d2de1e323
tree1a7332196907af1966807e1664e2734ba6bb41f7
parent880ef2da7b81fe2e4e9fb75f4677377eeba70d1e
[dev.link] cmd/internal/goobj2: add index fingerprint to object file

The new object files use indices for symbol references, instead
of names. Fundamental to the design, it requires that the
importing and imported packages have consistent view of symbol
indices. The Go command should already ensure this, when using
"go build". But in case it goes wrong, it could lead to obscure
errors like run-time crashes. It would be better to check the
index consistency at build time.

To do that, we add a fingerprint to each object file, which is
a hash of symbol indices. In the object file it records the
fingerprints of all imported packages, as well as its own
fingerprint. At link time, the linker checks that a package's
fingerprint matches the fingerprint recorded in the importing
packages, and issue an error if they don't match.

This CL does the first part: introducing the fingerprint in the
object file, and propagating fingerprints through
importing/exporting by the compiler. It is not yet used by the
linker. Next CL will do.

Change-Id: I0aa372da652e4afb11f2867cb71689a3e3f9966e
Reviewed-on: https://go-review.googlesource.com/c/go/+/229617
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
src/cmd/compile/internal/gc/iexport.go
src/cmd/compile/internal/gc/iimport.go
src/cmd/compile/internal/gc/main.go
src/cmd/internal/goobj/readnew.go
src/cmd/internal/goobj2/objfile.go
src/cmd/internal/obj/line.go
src/cmd/internal/obj/link.go
src/cmd/internal/obj/objfile.go
src/cmd/internal/obj/objfile2.go
src/cmd/internal/obj/sym.go
src/cmd/link/internal/loader/loader.go