]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] cmd/compile: more fix on boolean ops on ARM64
authorCherry Mui <cherryyz@google.com>
Mon, 9 May 2022 16:57:31 +0000 (12:57 -0400)
committerThan McIntosh <thanm@google.com>
Mon, 8 Aug 2022 16:24:37 +0000 (16:24 +0000)
commite1099eb289a3da3bfb9f69527e9931d75ff9799b
treebe890301004a0bdf9ea1d18ce284b0e62cece196
parente05bd7572247b680c3382c9f9c4e6e06179d5354
[release-branch.go1.18] cmd/compile: more fix on boolean ops on ARM64

Following CL 421457, the extension rule is also wrong. It is safe
to drop the extension if the value is from a boolean-generating
instruction, but not a boolean-typed Value in general (e.g. a Phi
or a in-register parameter). Fix it.

Updates #52788.
Updates #53397.

Change-Id: Icf3028fe8e90806f9f57fbe2b38d47da27a97e2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/405115
Reviewed-by: David Chase <drchase@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/421458
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/cmd/compile/internal/ssa/gen/ARM64.rules
src/cmd/compile/internal/ssa/rewriteARM64.go
test/fixedbugs/issue52788a.go [new file with mode: 0644]
test/fixedbugs/issue52788a.out [new file with mode: 0644]