]> Cypherpunks repositories - gostls13.git/commit
database/sql: fix TestPendingConnsAfterErr
authorDaniel Theophanes <kardianos@gmail.com>
Mon, 31 Oct 2016 14:58:41 +0000 (07:58 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 22 Nov 2016 23:35:56 +0000 (23:35 +0000)
commite12f6ee0ab1e7b4da818054d7ced4247c81fd164
treec183d38447f8fdd5d7536a9eab282a3a6b38dd94
parent199d410df5f52926add3cb6e1ad972a1135b40b1
database/sql: fix TestPendingConnsAfterErr

TestPendingConnsAfterErr showed a failure on slower systems.
Wait and check for the database to close all connections
before pronouncing failure.

A more careful method was attempted but the connection pool
behavior is too dependent on the scheduler behavior to be
predictable.

Fixes #15684

Change-Id: Iafdbc90ba51170c76a079db04c3d5452047433a4
Reviewed-on: https://go-review.googlesource.com/33418
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/database/sql/sql_test.go