]> Cypherpunks repositories - gostls13.git/commit
net: make TestInterfaceAddrsWithNetsh more robust
authorAlex Brainman <alex.brainman@gmail.com>
Wed, 10 Feb 2016 23:15:58 +0000 (10:15 +1100)
committerRuss Cox <rsc@golang.org>
Tue, 16 Feb 2016 17:16:00 +0000 (17:16 +0000)
commite136cac48c14aa85795625169379eeeddce35e4f
treede1c9efff84fbc90e3c2f90579691d36a870dd1b
parent0c02bc009a65763a5015e7efb95baec84bb79e8d
net: make TestInterfaceAddrsWithNetsh more robust

TestInterfaceAddrsWithNetsh invokes Windows netsh command passing
it a particular interface name. This approach somehow does not work
on some computers (see issue for details). Change that to call netsh
without specifying any interface name. This provides output for all
interfaces available. So we can achieve same goal parsing this output.
Also makes test faster because we only need to invoke netsh once.

Fixes #14130.

Change-Id: I7911692ca64e372af1e1f9d6acb718c67071de67
Reviewed-on: https://go-review.googlesource.com/19441
Reviewed-by: Volker Dobler <dr.volker.dobler@gmail.com>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/net/net_windows_test.go