]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.3] cmd/6g: fix stack zeroing on native client
authorRuss Cox <rsc@golang.org>
Sat, 7 Jun 2014 02:07:21 +0000 (22:07 -0400)
committerRuss Cox <rsc@golang.org>
Sat, 7 Jun 2014 02:07:21 +0000 (22:07 -0400)
commite16c88a5e7b36aae7bef804d946a03af76f29960
tree490a123721106c05e3d79cb184de51566bf61029
parent2dbe352b0f34189045800bc3857a3c0b300c6f42
[release-branch.go1.3] cmd/6g: fix stack zeroing on native client

««« CL 108740047 / c8e9255aed3f
cmd/6g: fix stack zeroing on native client

I am not sure what the rounding here was
trying to do, but it was skipping the first
pointer on native client.

The code above the rounding already checks
that xoffset is widthptr-aligned, so the rnd
was a no-op everywhere but on Native Client.
And on Native Client it was wrong.

Perhaps it was supposed to be rounding down,
not up, but zerorange handles the extra 32 bits
correctly, so the rnd does not seem to be necessary
at all.

This wouldn't be worth doing for Go 1.3 except
that it can affect code on the playground.

Fixes #8155.

LGTM=r, iant
R=golang-codereviews, r, iant
CC=dvyukov, golang-codereviews, khr
https://golang.org/cl/108740047
»»»

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, r
https://golang.org/cl/107830044
src/cmd/6g/ggen.c
test/fixedbugs/issue8155.go [new file with mode: 0644]