]> Cypherpunks repositories - gostls13.git/commit
hash: update documentation for MakeTable in crc32 and crc64
authorJoe Tsai <joetsai@digital-static.net>
Thu, 3 Sep 2015 22:24:53 +0000 (15:24 -0700)
committerIan Lance Taylor <iant@golang.org>
Fri, 4 Sep 2015 02:16:27 +0000 (02:16 +0000)
commite16d80362d9a6270e5c28160828a241f775c18e1
tree15c81c66e1f4c612553378204763e9923030932d
parentc788a8e05df9b75c53fac9d588d595329912c38b
hash: update documentation for MakeTable in crc32 and crc64

Explicitly say that *Table returned by MakeTable may not be
modified. Otherwise, this leads to very subtle bugs that may
or may not manifest themselves.

Same comment was made on package crc64, to keep the future
open to the caching tables that crc32 effectively does.

Fixes: #12487.
Change-Id: I2881bebb8b16f6f8564412172774c79c2593c6c1
Reviewed-on: https://go-review.googlesource.com/14258
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/hash/crc32/crc32.go
src/hash/crc64/crc64.go