]> Cypherpunks repositories - gostls13.git/commit
cmd/go: deflake TestScript/gcflags_patterns
authorJay Conrod <jayconrod@google.com>
Fri, 4 Jan 2019 22:30:36 +0000 (17:30 -0500)
committerJay Conrod <jayconrod@google.com>
Mon, 7 Jan 2019 17:55:24 +0000 (17:55 +0000)
commite1b903788ac5e35ed0d0fb20d904eafedca02c81
tree66495b2805e46002f6d27d239ac0df8bcd66cc2e
parent73fb3c38a685158591503a3d760ae6e1d1a2a565
cmd/go: deflake TestScript/gcflags_patterns

The check below can fail incorrectly if the buildid ends with '-p'.

    ! stderr 'compile.* -e .*-p [^z]'

This fix changes regular expressions to '-e.* -p' or '-N.* -p' instead
of '-e .*-p'. '-l' is no longer used because the compiler accepts
multiple flags starting with '-l' ('-e' and '-N' do not have this
problem), so there could be false matches.

Change-Id: I827c411de28624019a287f853acc9666e87cbfb9
Reviewed-on: https://go-review.googlesource.com/c/156327
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/go/testdata/script/gcflags_patterns.txt