]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] runtime: set vdsoSP to caller's SP consistently
authorCherry Mui <cherryyz@google.com>
Wed, 22 Sep 2021 22:32:45 +0000 (18:32 -0400)
committerCherry Mui <cherryyz@google.com>
Mon, 7 Feb 2022 22:08:13 +0000 (22:08 +0000)
commite2277c8dd4fb349a3d6b10ae8d1735c8e86956b7
tree00b6154cf295f203ded9675d28e18b418b06e856
parent5ef95666946dd744c0392166981783f72687993f
[release-branch.go1.16] runtime: set vdsoSP to caller's SP consistently

m.vdsoSP should be set to the SP of the caller of nanotime1,
instead of the SP of nanotime1 itself, which matches m.vdsoPC.
Otherwise the unmatched vdsoPC and vdsoSP would make the stack
trace look like recursive.

We already do it correctly on AMD64, 386, and RISCV64. This CL
fixes the rest.

Also incorporate CL 352509, skipping a flaky test.

Updates #47324, #50772.
Fixes #50780.

Change-Id: I98b6fcfbe9fc6bdd28b8fe2a1299b7c505371dd4
Reviewed-on: https://go-review.googlesource.com/c/go/+/337590
Trust: Cherry Mui <cherryyz@google.com>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
(cherry picked from commit 217507eb035933bac6c990844f0d71d6000fd339)
Reviewed-on: https://go-review.googlesource.com/c/go/+/380716
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/pprof/pprof_test.go
src/runtime/sys_linux_arm.s
src/runtime/sys_linux_arm64.s
src/runtime/sys_linux_mips64x.s
src/runtime/sys_linux_ppc64x.s