]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/ssa: restrict architectures for TestDebugLines_74576
authorthepudds <thepudds1460@gmail.com>
Fri, 18 Jul 2025 22:25:08 +0000 (18:25 -0400)
committert hepudds <thepudds1460@gmail.com>
Sat, 19 Jul 2025 12:33:40 +0000 (05:33 -0700)
commite32255fcc0861727243fca4e94766c0a322954fb
tree72e82735310dd0b25ef6b0b5bcf852f0e7c911ae
parent0451816430486a25966dd76aa92735ac0588b8e5
cmd/compile/internal/ssa: restrict architectures for TestDebugLines_74576

CL 687815 recently added TestDebugLines_74576.

The pre-existing debug_lines_test.go file generally restricts the
tested architectures and contains multiple warnings that the
testing approach is useful but fragile, such as:

  "These files must all be short because this is super-fragile."

Despite that, initially I wanted to see what happened on the
different architectures on the trybots in case it might show something
surprising, and I let TestDebugLines_74576 run on all architectures.

That seemed to initially work, but the test is now failing on a
linux/risc64 builder (#74669), so it is likely more prudent to be
more conservative and restrict the platforms like many of the
other pre-existing tests, which is what this CL now does.

Fixes #74669

Change-Id: I9e5a7d3ee901f58253cf72e03c2239df338479e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/688856
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/ssa/debug_lines_test.go