]> Cypherpunks repositories - gostls13.git/commit
cmd/vet: diagnose non-space-separated struct tag like `json:"x",xml:"y"`
authorRuss Cox <rsc@golang.org>
Tue, 25 Oct 2016 19:44:14 +0000 (15:44 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 26 Oct 2016 13:37:51 +0000 (13:37 +0000)
commite3324a4b6640da2dc8d3f086a8ed490aedae7091
tree69a2e53dfc7cfab58af57c72fc7fc489f44eec49
parent3202aa7800aeb523a7af2015241f96e9ae46bfbc
cmd/vet: diagnose non-space-separated struct tag like `json:"x",xml:"y"`

This is not strictly illegal but it probably should be (too late)
and doesn't mean what it looks like it means:
the second key-value pair has the key ",xml".

Fixes #14466.

Change-Id: I174bccc23fd28affeb87f57f77c6591634ade641
Reviewed-on: https://go-review.googlesource.com/32031
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Quentin Smith <quentin@golang.org>
src/cmd/vet/structtag.go
src/cmd/vet/testdata/structtag.go