]> Cypherpunks repositories - gostls13.git/commit
go/internal/gcimporter: don't waste CPU copying bytes in `io.ReadAll`
authorSergey Zagursky <gvozdoder@gmail.com>
Fri, 4 Jun 2021 09:25:51 +0000 (12:25 +0300)
committerMatthew Dempsky <mdempsky@google.com>
Sat, 5 Jun 2021 09:28:43 +0000 (09:28 +0000)
commite3cb3817049ca5e9d96543500b72117f6ca659b8
treee14e85c0f8adeed43960481d9188984ae7575a06
parent9d669ed47a502ca540c7f3329f84d89fc0c53971
go/internal/gcimporter: don't waste CPU copying bytes in `io.ReadAll`

`io.ReadAll` dynamically reallocates byte slice because it doesn't know
its size in advance. We don't need to read an entire file into memory
and therefore may use `bufio.Reader` to read its contents.

Fixes #46564

Change-Id: Id504b1512662b6dea4775d523455896fa4162ab3
Reviewed-on: https://go-review.googlesource.com/c/go/+/325429
Reviewed-by: Dominik Honnef <dominik@honnef.co>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dominik Honnef <dominik@honnef.co>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
src/go/internal/gcimporter/gcimporter.go
src/go/internal/gcimporter/iimport.go