]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/work: make toolchain builds reproducible when buildmode=pie
authorElias Naur <mail@eliasnaur.com>
Sun, 7 Apr 2019 13:02:31 +0000 (15:02 +0200)
committerElias Naur <mail@eliasnaur.com>
Mon, 8 Apr 2019 20:38:29 +0000 (20:38 +0000)
commite4665da9bcdd4e9136c7ed97ab4253def130b89d
tree6e602e130b40f4606f2bed7f3c7ee375e731f491
parentf18c31a49c1105be0341b32392a433cf65f227da
cmd/go/internal/work: make toolchain builds reproducible when buildmode=pie

When buildmode=pie, external linking is forced, and our toolchain build id
will be included in the external build id, resulting in the building of
a toolchain tool will never reach a fixed point id.

More importantly, this change will make make.bash converge on self-hosted
Android builds (Android refuses to run non-PIE executables).

Fixes #31320
Updates #18968

Change-Id: Icb5db9f4b1b688afe37f4dafe261ffda580fa4e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/170942
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/internal/work/gc.go
src/cmd/internal/sys/supported.go
src/cmd/link/internal/ld/config.go