]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.5] runtime: avoid stat underflow crash
authorAustin Clements <austin@google.com>
Mon, 16 Nov 2015 04:09:16 +0000 (23:09 -0500)
committerAustin Clements <austin@google.com>
Tue, 17 Nov 2015 02:25:04 +0000 (02:25 +0000)
commite49330911f52bcb2aeb7eae4ca6df4fc8a013abe
treedc301867041e7f62c00de549648e977703f105e6
parent20a053611b2ac6cdd760fd3d391e4f7ae2d72a77
[release-branch.go1.5] runtime: avoid stat underflow crash

If the area returned by sysReserve in mheap.sysAlloc is outside the
usable arena, we sysFree it. We pass a fake stat pointer to sysFree
because we haven't added the allocation to any stat at that point.
However, we pass a 0 stat, so sysFree panics when it decrements the
stat because the fake stat underflows.

Fix this by setting the fake stat to the allocation size.

Updates #13143 (this is a prerequisite to fixing that bug).

Change-Id: I61a6c9be19ac1c95863cf6a8435e19790c8bfc9a
Reviewed-on: https://go-review.googlesource.com/16926
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/16987
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/malloc.go