]> Cypherpunks repositories - gostls13.git/commit
runtime: add threadprof tag for test that starts busy thread
authorIan Lance Taylor <iant@golang.org>
Wed, 5 Oct 2016 14:31:11 +0000 (07:31 -0700)
committerIan Lance Taylor <iant@golang.org>
Thu, 6 Oct 2016 01:23:09 +0000 (01:23 +0000)
commite5421e21effb5b1db4e565babbddffeb4103d40e
tree40ba512afd94405ac10a6dc8d78fe52333f4c93d
parent5fd6bb4c14b395bc413f281987225b57ae5fe67c
runtime: add threadprof tag for test that starts busy thread

The CgoExternalThreadSIGPROF test starts a thread at constructor time
that does a busy loop. That can throw off some other tests. So only
build that code if testprogcgo is built with the tag threadprof, and
adjust the tests that use that code to pass that build tag.

This revealed that the CgoPprofThread test was not testing what it
should have, as it never actually started the cpuHog thread. It was
passing because of the busy loop thread. Fix it to start the thread as
intended.

Change-Id: I087a9e4fc734a86be16a287456441afac5676beb
Reviewed-on: https://go-review.googlesource.com/30362
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/crash_cgo_test.go
src/runtime/testdata/testprogcgo/threadpprof.go
src/runtime/testdata/testprogcgo/threadprof.go