]> Cypherpunks repositories - gostls13.git/commit
runtime: look for idle p to run current goroutine when switching to GC or traceReader
authorDavid Chase <drchase@google.com>
Thu, 1 Nov 2018 21:31:20 +0000 (17:31 -0400)
committerDavid Chase <drchase@google.com>
Wed, 1 May 2019 16:10:05 +0000 (16:10 +0000)
commite56c73f17b49793f9c57c0706344afafbec726d1
treef94143470c7175b5eaecd5e1699507374b5934d9
parent45be3530a32dfe759d992f488a42e7495fcebd19
runtime: look for idle p to run current goroutine when switching to GC or traceReader

This repairs one of the several causes of pauses uncovered
by a GC microbenchmark.  A pause can occur when a goroutine's
quantum expires "at the same time" a GC is needed.  The
current M switches to running a GC worker, which means that
the amount of available work has expanded by one.  The GC
worker, however, does not call ready, and does not itself
conditionally wake a P (a "normal" thread would do this).

This is also true if M switches to a traceReader.

This is problem 4 in this list:
https://github.com/golang/go/issues/27732#issuecomment-423301252

Updates #27732.

Change-Id: I6905365cac8504cde6faab2420f4421536551f0b
Reviewed-on: https://go-review.googlesource.com/c/go/+/146817
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/runtime/proc.go