]> Cypherpunks repositories - gostls13.git/commit
net/http: make ExampleGet show StatusCode checks for non-1XX,2XX responses
authorEmmanuel T Odeke <emmanuel@orijtech.com>
Sun, 7 Mar 2021 22:56:52 +0000 (14:56 -0800)
committerDamien Neil <dneil@google.com>
Fri, 19 Mar 2021 16:12:45 +0000 (16:12 +0000)
commite58fb90c753ce8ac1ccd6e26035e7ec0f4f108bc
treeff5f3a725233d67bdf0e2f1474740a4dcc1f8cd6
parenta937729c2c2f6950a32bc5cd0f5b88700882f078
net/http: make ExampleGet show StatusCode checks for non-1XX,2XX responses

Updates ExampleGet to show how to handle bad responses with non-1XX,2XX
status codes. Given that the canonical examples are copied, we need
to have them properly check against failures. This is a bug I've seen
often in the wild, that's exacerbated when for example unmarshalling
JSON or even protobufs, and no errors are returned by the decoders,
so code fails silently after making a request for example to a gateway
that they were unauthorized to access.

Fixes #39778

Change-Id: I1cd688f2fab47581c8cf228235d3662b4c8e4315
Reviewed-on: https://go-review.googlesource.com/c/go/+/299609
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/http/example_test.go