]> Cypherpunks repositories - gostls13.git/commit
net/http: remove arbitrary timeout in TestServerHijackGetsBackgroundByte_big
authorBryan C. Mills <bcmills@google.com>
Tue, 7 Dec 2021 03:09:12 +0000 (22:09 -0500)
committerDamien Neil <dneil@google.com>
Tue, 7 Dec 2021 17:52:27 +0000 (17:52 +0000)
commite5ba7d3abf1e356f8cb7d760f95a389dd08c63ae
tree5d5d0192ee08df971873e293256accb5ad93310c
parent4c943abb95578da4bfd70d365814a130da8d5aa2
net/http: remove arbitrary timeout in TestServerHijackGetsBackgroundByte_big

This test fails with "timeout" once per couple of months.
It may be that the arbitrary timeout is too short,
or it may be that the test is detecting a real bug
(perhaps a deadlock) and reporting it without sufficient
information to debug.

Either way, the arbitrary timeout is doing only harm:
either it is too short, or it is preventing us from getting
a useful goroutine dump when the test inevitably times out.

Fixes #35498 (hopefully).

Change-Id: Ic6bbb1ef8df2c111b9888ba9903f58633e7cb95d
Reviewed-on: https://go-review.googlesource.com/c/go/+/369854
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/http/serve_test.go