]> Cypherpunks repositories - gostls13.git/commit
os/exec: constrain thread usage in leaked descriptor test on illumos
authorJoshua M. Clulow <josh@sysmgr.org>
Mon, 30 Nov 2020 01:18:51 +0000 (17:18 -0800)
committerIan Lance Taylor <iant@golang.org>
Mon, 30 Nov 2020 03:18:36 +0000 (03:18 +0000)
commite5da18df52e3f81534d7cdb6920cf993b5f079d2
tree25dedf3d7372a2297fdf4dfdf7fac2dbf838a5c5
parent4ce0a7cea6805277c3bfecbaab2170e5c2543cba
os/exec: constrain thread usage in leaked descriptor test on illumos

On illumos systems, libc can under some conditions make use of files
from /proc.  In the case of this test, the creation of new threads was
(in the target thread) causing libc to open and close
"/proc/self/lwp/5/lwpname" to set the thread name, which raced with the
leaking descriptor check (see detailed analysis in #42431).

This change requests that the Go runtime use less threads in the child
process used to check for leaked descriptors, without just disabling the
test.  After a thousand repeated trials, the test no longer fails on
illumos.

Fixes #42431.

Change-Id: Iefda26134fc91f7cb205754676e9845d9b7205cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/273966
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
src/os/exec/exec_test.go