]> Cypherpunks repositories - gostls13.git/commit
cmd/go: clarify promotion of C warnings to errors
authorAustin Clements <austin@google.com>
Thu, 24 Aug 2023 19:14:44 +0000 (15:14 -0400)
committerGopher Robot <gobot@golang.org>
Thu, 24 Aug 2023 19:48:50 +0000 (19:48 +0000)
commite63be91667aeaafe2ce32c4da69f89097e074bbc
treea4568dd95027d31828106eebe456eaeca194317f
parentf0b05092fd9bbfc698cb3bd24c6ae042e9c54616
cmd/go: clarify promotion of C warnings to errors

CL 23005 (back in 2016!) added logic to promote C compiler warnings to
errors when running on the Go builders.

CL 437298 kept the logic to promote warnings to errors on the
builders, but dropped the explanatory message, I believe
unintentionally. Indeed, now there isn't even a comment in the code
explaining what's going on.

This CL adds back an explanatory message to the printed output, which
also serves as a explanation in the code as to why we're checking
$GO_BUILDER_NAME.

Change-Id: I769c55d213f96f73d20a41ab926fb91e71a5a22c
Reviewed-on: https://go-review.googlesource.com/c/go/+/522775
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/go/internal/work/exec.go