]> Cypherpunks repositories - gostls13.git/commit
cmd/trace: avoid emitting traceview slice with 0 duration
authorHana Kim <hakim@google.com>
Wed, 4 Apr 2018 17:47:53 +0000 (13:47 -0400)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Wed, 4 Apr 2018 18:15:20 +0000 (18:15 +0000)
commite6ab614fda5ce7533bda81f2b0de0f9fe18139bf
tree32fa0f038454cb17928a8cfe8280b3a030265efd
parentc4874aa2a207e8c9a3c79a9411a54cce4808aa9e
cmd/trace: avoid emitting traceview slice with 0 duration

The trace viewer interprets the slice as a non-terminating
time interval which is quite opposit to what trace records indicate
(i.e., almostly immediately terminating time interval).
As observed in the issue #24663 this can result in quite misleading
visualization of the trace.

Work around the trace viewer's issue by setting a small value
(0.0001usec) as the duration if the time interval is not positive.

Change-Id: I1c2aac135c194d0717f5c01a98ca60ffb14ef45c
Reviewed-on: https://go-review.googlesource.com/104716
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/trace/trace.go