]> Cypherpunks repositories - gostls13.git/commit
runtime: skip TestArenaCollision on failed reservation
authorAustin Clements <austin@google.com>
Tue, 1 Nov 2022 14:00:25 +0000 (10:00 -0400)
committerAustin Clements <austin@google.com>
Tue, 1 Nov 2022 17:06:23 +0000 (17:06 +0000)
commite72da1c15dc273b39dcb5dd87c56d5713dbc1b37
tree137db1644062074d677721da4d1655d2964a010e
parent61ae0a37a8c96e2b1745594e477244100f1a7046
runtime: skip TestArenaCollision on failed reservation

If TestArenaCollision cannot reserve the address range it expects to
reserve, it currently fails somewhat mysteriously. Detect this case
and skip the test. This could lead to test rot if we wind up always
skipping this test, but it's not clear that there's a better answer.
If the test does fail, we now also log what it thinks it reserved so
the failure message is more useful in debugging any issues.

Fixes #49415
Fixes #54597

Change-Id: I05cf27258c1c0a7a3ac8d147f36bf8890820d59b
Reviewed-on: https://go-review.googlesource.com/c/go/+/446877
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/export_test.go
src/runtime/malloc_test.go