]> Cypherpunks repositories - gostls13.git/commit
cmd/go: fix tests that fail when running a cross-compiled GOARCH
authorBryan C. Mills <bcmills@google.com>
Thu, 1 Feb 2024 20:56:05 +0000 (15:56 -0500)
committerGopher Robot <gobot@golang.org>
Mon, 5 Feb 2024 14:52:04 +0000 (14:52 +0000)
commite8d87728bd4ac93ed207df1261da673749c6bd0c
tree83229be74d64af559dce15fe16e117bfd90c3357
parentb8ac61e6e64c92f23d8cf868a92a70d13e20a124
cmd/go: fix tests that fail when running a cross-compiled GOARCH

In CL 356611 I changed cmd/go to run most of its tests (instead of
skipping them all) when cross-compiled, such as with GOARCH=386 on an
amd64 host. Unfortunately, since we don't have a CI builder that runs
long tests in a cross-compiled configuration, some of the tests have
rotted since then.

This fixes 'GOARCH=386 go test cmd/go' on my workstation.

For #64963.
Updates #53936.

Change-Id: If7f4bc8e8d1ace7d36010d7a1b652fc7b2ceb276
Cq-Include-Trybots: luci.golang.try:gotip-linux-386-longtest,gotip-windows-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/560782
Auto-Submit: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/cmd/go/scriptconds_test.go
src/cmd/go/testdata/script/README
src/cmd/go/testdata/script/build_plugin_reproducible.txt
src/cmd/go/testdata/script/version.txt
src/cmd/go/testdata/script/version_cshared.txt