]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix mis-compilation with labeled fallthrough
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Sun, 3 Nov 2024 14:27:00 +0000 (21:27 +0700)
committerGopher Robot <gobot@golang.org>
Mon, 4 Nov 2024 16:54:28 +0000 (16:54 +0000)
commitea38fa534559d1c25e629d0b1e96a730fa96780b
treee2bf710af8f27a1876810fe41e94ac38df4d2445
parent324f41b748fd87ad4a1cafa458bac3014f2fb5f2
cmd/compile: fix mis-compilation with labeled fallthrough

A fallthrough statement can be a labeled fallthrough per Go spec.
However, the hasFallthrough function is not considering this case,
causing mis-compilation.

Fixing this by un-wrapping (possible nested) labeled fallthrough
statements if any.

Fixes #70173

Change-Id: Ic93d4fb75ff02703a32dfc63c3e84a8b7f78c261
Reviewed-on: https://go-review.googlesource.com/c/go/+/624717
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Youlin Feng <fengyoulin@live.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/compile/internal/noder/writer.go
src/cmd/compile/testdata/script/issue70173.txt [new file with mode: 0644]