]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/types: remove unused lineno arguments for PushDcl/MarkDcl
authorRobert Griesemer <gri@golang.org>
Fri, 21 Apr 2017 18:11:15 +0000 (11:11 -0700)
committerRobert Griesemer <gri@golang.org>
Fri, 21 Apr 2017 19:41:11 +0000 (19:41 +0000)
commiteaf02e1fc9d5f22415233783c02bb0b687d216ec
treef019ac514ecbf02ad4dfdac52e4f1b685f118c2a
parent227fff2ea4f21ec357eebe27324cc04b7c9919c7
cmd/compile/internal/types: remove unused lineno arguments for PushDcl/MarkDcl

More steps towards simpler symbol handling:

- Pushdcl's incoming pos argument, saved in a newly pushed *Sym, was always
  immediately overwritten by the Lastlineno value of the saved *Sym.

- Markdcl's incoming pos argument, saved in the stack mark *Sym, was not
  restored when the stack mark was popped.

- Popdcl always maintained the most recent Lastlineno for a *Sym given
  by package and name, making it unnecessary to save Lastlineno in the
  first place. Removed Lastlineno from the set of fields that need saving,
  and simplified Popdcl.

Change-Id: Ie93da1fbd780dcafc2703044e781c0c6298df569
Reviewed-on: https://go-review.googlesource.com/41390
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/alg.go
src/cmd/compile/internal/gc/bimport.go
src/cmd/compile/internal/gc/dcl.go
src/cmd/compile/internal/gc/noder.go
src/cmd/compile/internal/gc/subr.go
src/cmd/compile/internal/types/scope.go
src/cmd/compile/internal/types/sym.go