]> Cypherpunks repositories - gostls13.git/commit
net/http: deflake TestServerAllowsBlockingRemoteAddr more
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 20 Mar 2017 16:44:34 +0000 (16:44 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 20 Mar 2017 17:32:16 +0000 (17:32 +0000)
commiteb6c1dd7ebd7035978eda533d1c0470261306bff
tree59eed30734d6375c1cefb0cacdf2723387dbf524
parentd80166ebbef1e57457dc383959af83ea2286726e
net/http: deflake TestServerAllowsBlockingRemoteAddr more

As noted in https://github.com/golang/go/issues/19161#issuecomment-287554171,
CL 37771 (adding use of the new httptest.Server.Client to all net/http
tests) accidentally reverted DisableKeepAlives for this test. For
many tests, DisableKeepAlives was just present to prevent goroutines
from staying active after the test exited.  In this case it might
actually be important. (We'll see)

Updates #19161

Change-Id: I11f889f86c932b51b11846560b68dbe5993cdfc3
Reviewed-on: https://go-review.googlesource.com/38373
Reviewed-by: Michael Munday <munday@ca.ibm.com>
src/net/http/serve_test.go