]> Cypherpunks repositories - gostls13.git/commit
go/types, types2: avoid 2nd lookup when looking for method on ptr recv
authorRobert Griesemer <gri@golang.org>
Mon, 6 Mar 2023 03:44:34 +0000 (19:44 -0800)
committerGopher Robot <gobot@golang.org>
Mon, 6 Mar 2023 21:18:42 +0000 (21:18 +0000)
commitebc2aaae245be6a83f9b342f4c0147011c2fd423
treeb966c5b749f4f61a846440ae239a254e5020b539
parent8f92ae1c63771e42b60ff64ea39d8d6ba602d8b2
go/types, types2: avoid 2nd lookup when looking for method on ptr recv

If a method is not found on a type V, for better error messages we
report if the method is on *V. There's no need to do a 2nd lookup
for that because the relevant information is readily returned by
lookupFieldOrMethod already.

Simplifies code and removes a long-standing TODO.

Change-Id: Ibdb2269b04c0db61bfe4641404ab1df330397b2d
Reviewed-on: https://go-review.googlesource.com/c/go/+/473655
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
src/cmd/compile/internal/types2/lookup.go
src/go/types/lookup.go