]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] net/http: preserve nil values in Header.Clone
authorDamien Neil <dneil@google.com>
Fri, 17 Jun 2022 17:09:45 +0000 (10:09 -0700)
committerMichael Knyszek <mknyszek@google.com>
Tue, 12 Jul 2022 14:51:53 +0000 (14:51 +0000)
commitebea1e3353fa766025aa5190b9c7cc05cf069187
tree8780a4d06a878f204c4b64b0575cc00a0d816537
parent222ee24a0046ae61679f4d97967e3b4058a3b90e
[release-branch.go1.18] net/http: preserve nil values in Header.Clone

ReverseProxy makes a distinction between nil and zero-length header values.
Avoid losing nil-ness when cloning a request.

Thanks to Christian Mehlmauer for discovering this.

For #53423
For CVE-2022-32148
Fixes #53621

Change-Id: Ice369cdb4712e2d62e25bb881b080847aa4801f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/412857
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit b2cc0fecc2ccd80e6d5d16542cc684f97b3a9c8a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/415222
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/net/http/header.go
src/net/http/header_test.go