]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15-security] cmd/go: in cgoflags, permit -DX1, prohibit -Wp,...
authorIan Lance Taylor <iant@golang.org>
Tue, 3 Nov 2020 05:31:06 +0000 (21:31 -0800)
committerKatie Hockman <katiehockman@google.com>
Wed, 11 Nov 2020 23:35:26 +0000 (23:35 +0000)
commitec06b6d6be568ce1591d91a0ea4f14c190d06605
tree55f128a69e570f9f36b288e9e982fa9779cefe4f
parent32159824698a82a174b60a6845e8494ae3243102
[release-branch.go1.15-security] cmd/go: in cgoflags, permit -DX1, prohibit -Wp,-D,opt

Restrict -D and -U to ASCII C identifiers, but do permit trailing digits.
When using -Wp, prohibit commas in -D values.

Thanks to Imre Rad (https://www.linkedin.com/in/imre-rad-2358749b) for reporting this.

Fixes CVE-2020-28367

Change-Id: Ibfc4dfdd6e6c258e131448e7682610c44eee9492
Reviewed-on: https://go-review.googlesource.com/c/go/+/267277
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/899924
Reviewed-by: Filippo Valsorda <valsorda@google.com>
src/cmd/go/internal/work/security.go
src/cmd/go/internal/work/security_test.go