]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.12] cmd/compile: make sure to initialize static entries of slices
authorKeith Randall <khr@google.com>
Mon, 13 May 2019 20:43:49 +0000 (13:43 -0700)
committerFilippo Valsorda <filippo@golang.org>
Tue, 14 May 2019 21:16:32 +0000 (21:16 +0000)
commitecf7695c7dcfc04becde0beec0e1c5f583b42e9e
treecfcb73d6ab344e04b53749deae6369696c9d1cfc
parentcdb776529ea7a4beac4c8a4d6a9ce149045bd6b5
[release-branch.go1.12] cmd/compile: make sure to initialize static entries of slices

If a slice's entries are sparse, we decide to initialize it dynamically
instead of statically. That's CL 151319.

But if we do initialize it dynamically, we still need to initialize
the static entries. Typically we do that, but the bug fixed here is
that we don't if the entry's value is itself an array or struct.

To fix, use initKindLocalCode to ensure that both static and
dynamic entries are initialized via code.

Fixes #32013

Change-Id: I1192ffdbfb5cd50445c1206c4a3d8253295201dd
Reviewed-on: https://go-review.googlesource.com/c/go/+/176904
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
(cherry picked from commit a9e107c85cf69d735ac81c29f4a354643e40b2b5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/177040
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/gc/sinit.go
test/fixedbugs/issue31987.go [new file with mode: 0644]