]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: reject low-order Curve25519 points
authorFilippo Valsorda <filippo@golang.org>
Wed, 19 Jun 2019 22:31:43 +0000 (18:31 -0400)
committerFilippo Valsorda <filippo@golang.org>
Thu, 20 Jun 2019 19:30:01 +0000 (19:30 +0000)
commitee63782fd6bde490b31db9fbb00677ac4094bdc4
tree47f91e4b638ecc43a52f3cd38c3fd0e99fc43b38
parent0884bca05a278e7f8783be3545a88a26b14dd4e4
crypto/tls: reject low-order Curve25519 points

The RFC recommends checking the X25519 output to ensure it's not the
zero value, to guard against peers trying to remove contributory
behavior.

In TLS there should be enough transcript involvement to mitigate any
attack, and the RSA key exchange would suffer from the same issues by
design, so not proposing a backport.

See #31846

Change-Id: I8e657f8ee8aa72c3f8ca3b124555202638c53f5e
Reviewed-on: https://go-review.googlesource.com/c/go/+/183039
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
src/crypto/tls/key_schedule.go