]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] internal/buildcfg: always enable regabi on AMD64
authorCherry Mui <cherryyz@google.com>
Mon, 2 Aug 2021 16:18:19 +0000 (12:18 -0400)
committerCherry Mui <cherryyz@google.com>
Wed, 11 Aug 2021 16:59:43 +0000 (16:59 +0000)
commiteeb7899137cda1c2cd60dab65ff41f627436db5b
tree62b709aaec0f5390b00b6c55899c4f4051a84869
parent0888a8cd2dc3ad66e30ccb30eae8fbed065ea0f7
[dev.typeparams] internal/buildcfg: always enable regabi on AMD64

In Go 1.17 we added register ABI on AMD64 on Linux/macOS/Windows
as a GOEXPERIMENT, on by default. In Go 1.18, we commit to always
enabling register ABI on AMD64.

Now "go build" for AMD64 always have goexperiment.regabi* tags
set. However, at bootstrapping cmd/dist does not set the tags
when building go_bootstrap. For this to work, unfortunately, we
need to hard-code AMD64 to use register ABI in runtime code.

Change-Id: I0b31e678e186b9cdeeb8502cd9e38ed0d7e72d4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/341151
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Austin Clements <austin@google.com>
src/internal/abi/abi_amd64.go
src/internal/abi/abi_generic.go
src/internal/buildcfg/exp.go
src/runtime/stubs.go