]> Cypherpunks repositories - gostls13.git/commit
internal/trace: don't assume GC will start and end on same P
authorAustin Clements <austin@google.com>
Thu, 9 Apr 2015 14:03:26 +0000 (10:03 -0400)
committerAustin Clements <austin@google.com>
Fri, 10 Apr 2015 18:21:41 +0000 (18:21 +0000)
commiteec6fdc90b64a4a2c579ef35b2ce6eaab1f62733
treea035894326913256627ac5ff2731e346b73ec019
parent7c37249639a1454c7e8958c4760cc906d18cba2e
internal/trace: don't assume GC will start and end on same P

Currently, GC disables preemption between the traceGCStart and
traceGCDone, so it never moves Ps. Consequently, the trace verifier
attaches information about GC to its per-P state and will fail if GC
starts on one P and ends on another.

GC will soon be preemptible and may end on a different P than it
began. Hence, this change lifts this per-P verifier state to global
state.

Change-Id: I82256e2baab1ff3c4453fec312079018423b4b51
Reviewed-on: https://go-review.googlesource.com/8714
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Rick Hudson <rlh@golang.org>
src/internal/trace/parser.go